Conversation
kibanamachine
added
release_note:skip
Contributor
|
Pinging @elastic/kibana-esql (Team:ESQL) |
stratoula
added
backport:prev-minor
v9.0.0
v8.16.0
Feature:ES|QL
Contributor
|
/ci |
Contributor
|
Needs to merge this first #195847 |
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Page load bundle
History
|
stratoula
approved these changes
Oct 15, 2024
Contributor
|
@elastic/security-detection-engine can you please review? It is a tiny change for you and I would love to merge before the FF 🙏 |
Contributor
|
As the review from the security team is just a unit test update I am going to mege this PR as I want this merged before the FF |
Contributor
Author
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/11347453951 |
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 15, 2024
This PR updates the ES|QL grammars (lexer and parser) to match the latest version in Elasticsearch. --------- Co-authored-by: Stratoula Kalafateli <efstratia.kalafateli@elastic.co> (cherry picked from commit bed5c4e)
Contributor
Author
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 15, 2024
# Backport This will backport the following commits from `main` to `8.x`: - [[ES|QL] Update grammars (#196046)](#196046) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Kibana Machine","email":"42973632+kibanamachine@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-10-15T13:47:08Z","message":"[ES|QL] Update grammars (#196046)\n\nThis PR updates the ES|QL grammars (lexer and parser) to match the\r\nlatest version in Elasticsearch.\r\n\r\n---------\r\n\r\nCo-authored-by: Stratoula Kalafateli <efstratia.kalafateli@elastic.co>","sha":"bed5c4e9fe0cf5acc2e5b3326ca306134bc18891","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","Feature:ES|QL","Team:ESQL","v8.16.0"],"title":"[ES|QL] Update grammars","number":196046,"url":"https://github.com/elastic/kibana/pull/196046","mergeCommit":{"message":"[ES|QL] Update grammars (#196046)\n\nThis PR updates the ES|QL grammars (lexer and parser) to match the\r\nlatest version in Elasticsearch.\r\n\r\n---------\r\n\r\nCo-authored-by: Stratoula Kalafateli <efstratia.kalafateli@elastic.co>","sha":"bed5c4e9fe0cf5acc2e5b3326ca306134bc18891"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196046","number":196046,"mergeCommit":{"message":"[ES|QL] Update grammars (#196046)\n\nThis PR updates the ES|QL grammars (lexer and parser) to match the\r\nlatest version in Elasticsearch.\r\n\r\n---------\r\n\r\nCo-authored-by: Stratoula Kalafateli <efstratia.kalafateli@elastic.co>","sha":"bed5c4e9fe0cf5acc2e5b3326ca306134bc18891"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT-->
rylnd
reviewed
Oct 16, 2024
Contributor
rylnd
left a comment
rylnd
left a comment
There was a problem hiding this comment.
Security Solution change (which is a single test asserting an ES|QL validation error) looks good to me!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the ES|QL grammars (lexer and parser) to match the latest version in Elasticsearch.